re-write trace macro as a proc macro #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerTaule
force-pushed
the
sam-trace-macro
branch
from
6ec2e8a
to
d12ef4c
Compare
RogerTaule
force-pushed
the
sam-trace-macro
branch
4 times, most recently
from
f898c60
to
9b9c9c5
Compare
RogerTaule
force-pushed
the
sam-trace-macro
branch
from
9b9c9c5
to
c776f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace!macro as a proc macro, fixing the calculation ofROW_NUMBERand doing this calculation entirely at compile time instead of at const eval timetrace!macro, covering parsing edge cases and code generationtrace!macrocurrently one test still failing 2D arrays: https://github.com/0xPolygonHermez/pil2-proofman/actions/runs/10745134827/job/29803546597?pr=37